[PATCH] D48051: LTO: Work around a Windows kernel bug by keeping file handles open for memory mapped files.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 11 20:12:57 PDT 2018


zturner added a comment.

Alright, if there is no way to get rid of the Duplicates then we can live with them.  As you said, the proposed solution is already better than before.  I mildly prefer just never setting the delete on close flag in the first place because the case that it address is so rare that it almost doesn't even matter IMO, and I think just reducing the surface area of the Windows' kernels code paths that we touch is a win given how subtle this bug was and how long it took us to figure out.  But if you think we should have it then I won't make a big fuss over it :)


https://reviews.llvm.org/D48051





More information about the llvm-commits mailing list