[PATCH] D48051: LTO: Work around a Windows kernel bug by keeping file handles open for memory mapped files.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In https://reviews.llvm.org/D48051#1129149, @zturner wrote:

> We can’t transfer ownership of the handle in that case? With the flag
>  cleared we shouldn’t have to worry about the pending delete error


No because in those cases another program owns the file handle.

In this case gold owns the file handle: http://llvm-cs.pcc.me.uk/tools/gold/gold-plugin.cpp#498
and in this case the user of the C LTO API owns it: http://llvm-cs.pcc.me.uk/lib/LTO/LTOModule.cpp#134

In both cases the owner of the file handle is on the other end of a stable API.


https://reviews.llvm.org/D48051