[PATCH] D47602: Correct aligment computation for shared object symbols

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: ELF/InputFiles.cpp:901
+  // alignment information.
+  if (Sym.st_shndx == SHN_COMMON && Sym.st_value)
     Ret = 1ULL << countTrailingZeros((uint64_t)Sym.st_value);
----------------
ruiu wrote:
> Are you sure if this is correct?
It doesn't look right to me -- a dynamic symbol table should not contain symbols in `SHN_COMMON`.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47602