[PATCH] D47602: Correct aligment computation for shared object symbols

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 31 13:26:53 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/InputFiles.cpp:901
+  // alignment information.
+  if (Sym.st_shndx == SHN_COMMON && Sym.st_value)
     Ret = 1ULL << countTrailingZeros((uint64_t)Sym.st_value);
----------------
Are you sure if this is correct?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47602





More information about the llvm-commits mailing list