[PATCH] D47500: [WebAssembly] Add support for response file parsing

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: wasm/Driver.cpp:145
   unsigned MissingCount;
   opt::InputArgList Args = this->ParseArgs(Vec, MissingIndex, MissingCount);
 
----------------
ruiu wrote:
> sbc100 wrote:
> > ruiu wrote:
> > > I think you should add ExpandResponseFiles before this line.
> > ParseArgs is called twice, once before and once after.    This is the how COFF and ELF do it too.
> But you don't need to cargo-cult that, no?
Oh, sorry yes.  The double parsing is only needed in order to handle OPT_rsp_quoting which I removed from this change.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47500