[PATCH] D47500: [WebAssembly] Add support for response file parsing

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: test/wasm/responsefile.test:3
+
+RUN: echo -o %t.wasm -e ret32 %t.o > %t.rsp
+RUN: wasm-ld @%t.rsp --initial-memory=655360
----------------
It is perhaps better to move `%t.o` before `-o` so that `-o` would never be interpreted as an argument for the echo command.


================
Comment at: test/wasm/responsefile.test:9-10
+RUN: echo "blah\foo" > %t.rsp
+RUN: not wasm-ld @%t.rsp 2>&1 | \
+RUN:     FileCheck --check-prefix=ESCAPE %s
+ESCAPE: error: cannot open blahfoo: No such file or directory
----------------
Looks like this can fit in one line.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47500