[PATCH] D47330: [DAGCombiner] match vector compare and select sizes with extload operand (PR37427)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:7271
+          SetCCWidth != 1 && SetCCWidth < WideWidth &&
+          TLI.isOperationLegalOrCustom(LoadExtOpcode, WideVT) &&
+          TLI.isOperationLegalOrCustom(ISD::SETCC, WideVT)) {
----------------
craig.topper wrote:
> Shouldn't this be isLoadExtLegalOrCustom? I think ZEXTLOAD/SEXTLOAD will always be considered Legal for isOperationLegalOrCustom. Nothing makes them illegal in the OpActions array. isLoadExtLegalOrCustom uses a different array.
Maybe worse than that. ISD::SEXTLOAD/ISD::ZEXTLOAD aren't opcodes. They're in their own enum. I think this aliased to asking about EntryToken and TokenFactor?


https://reviews.llvm.org/D47330