[PATCH] D47153: [Support] Avoid normalization in sys::getDefaultTargetTriple

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 11:08:03 PDT 2018


delcypher added a comment.

I'm not familiar with this code but if I'm reading the patch correctly, then the commit message omits the fact that it changes he windows target triple from having a `win32` suffix to `windows-msvc` suffix. I'm not sure what the implications are here but the fact you've done this is probably worth mentioning in the commit message.


Repository:
  rL LLVM

https://reviews.llvm.org/D47153





More information about the llvm-commits mailing list