[PATCH] D47153: [Support] Avoid normalization in sys::getDefaultTargetTriple

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 21 21:58:22 PDT 2018

phosek added a comment.

In https://reviews.llvm.org/D47153#1106780, @delcypher wrote:

> I'm not familiar with this code but if I'm reading the patch correctly, then the commit message omits the fact that it changes he windows target triple from having a `win32` suffix to `windows-msvc` suffix. I'm not sure what the implications are here but the fact you've done this is probably worth mentioning in the commit message.

Done. I've also tested this change on Windows and this seems to be passing now so should be ready for re-land.



More information about the llvm-commits mailing list