[PATCH] D47088: Fix aliasing of launder.invariant.group

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:435
+        // Note: getArgumentAliasingToReturnedPointer keeps CaptureTracking in
+        // sync, which is needed for correctness.
+        if (auto *RP = getArgumentAliasingToReturnedPointer(CS)) {
----------------
Please explain here *how* this keeps this in sync. There's no obvious use of CaptureTracking here.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:3445
+        // Note: getArgumentAliasingToReturnedPointer keeps CaptureTracking in
+        // sync, which is needed for correctness.
+        if (auto *RP = getArgumentAliasingToReturnedPointer(CS)) {
----------------
Same here. Please explain how this helps to keep tings in sync with CaptureTracking. There's some implicit contract here between these functions that we need to document explicitly.


Repository:
  rL LLVM

https://reviews.llvm.org/D47088