[PATCH] D47088: Fix aliasing of launder.invariant.group

Piotr Padlewski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 19 16:03:20 PDT 2018


Prazek marked 2 inline comments as done.
Prazek added inline comments.


================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:435
+        // Note: getArgumentAliasingToReturnedPointer keeps CaptureTracking in
+        // sync, which is needed for correctness.
+        if (auto *RP = getArgumentAliasingToReturnedPointer(CS)) {
----------------
hfinkel wrote:
> Please explain here *how* this keeps this in sync. There's no obvious use of CaptureTracking here.
I updated the comment, but I have a new idea how to make it better. I will refactor the list of intrinsic to some other function, to make it always in sync.


Repository:
  rL LLVM

https://reviews.llvm.org/D47088





More information about the llvm-commits mailing list