[PATCH] D46953: [FastISel] Permit instructions to be skipped for FastISel generation.

[Simon Dardis via Phabricator via llvm-commits]

sdardis added a comment.

> Is the intent here just to bail early in order to save compile time?

The intent here is to deal with instructions like addu16 in microMIPS by excluding them from consideration for FastISel altogether as currently they can't be handled:

>   cd /Users/sdardis/dev/llvm/llvmbuild3 && /Users/sdardis/dev/llvm/llvmbuild3/bin/llvm-tblgen -gen-fast-isel -I /Users/sdardis/dev/llvm/llvm/lib/Target/Mips -I /Users/sdardis/dev/llvm/llvm/include -I /Users/sdardis/dev/llvm/llvm/lib/Target /Users/sdardis/dev/llvm/llvm/lib/Target/Mips/Mips.td -o lib/Target/Mips/MipsGenFastISel.inc.tmp -d lib/Target/Mips/MipsGenFastISel.inc.d
>   Included from /Users/sdardis/dev/llvm/llvm/lib/Target/Mips/Mips.td:60:
>   Included from /Users/sdardis/dev/llvm/llvm/lib/Target/Mips/MipsInstrInfo.td:3185:
>   /Users/sdardis/dev/llvm/llvm/lib/Target/Mips/MicroMipsInstrInfo.td:747:3: error: Duplicate predicate in FastISel table!

This error occurs wile building LLVM with the https://reviews.llvm.org/D46956 applied and a similar error for the attached test case. This patch allows FastISel generation to succeed.


Repository:
  rL LLVM

https://reviews.llvm.org/D46953