[PATCH] D40405: [AMDGPU] Fix handling of void types in isLegalAddressingMode

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 17 14:56:34 PDT 2018


rampitec added a comment.

In https://reviews.llvm.org/D40405#1102663, @arsenm wrote:

> In https://reviews.llvm.org/D40405#1102009, @rampitec wrote:
>
> > In https://reviews.llvm.org/D40405#1100698, @arsenm wrote:
> >
> > > Test should go in test/LoopStrengthReduce/AMDGPU and run just LSR
> >
> >
> > I can move the test, but I cannot reproduce the bug with opt.
>
>
> You should only change the test if the original problem shows up. You should be able to coax it into failing with just opt though (maybe you need to run more passes before LSR on it?)


Test is not changed, just moved. Note that many of our lsr tests there use llc to run. I was unable to make it reproducible with opt given any pass set. If one wants to run it with opt it will probably require a different test.


Repository:
  rL LLVM

https://reviews.llvm.org/D40405





More information about the llvm-commits mailing list