[lld] r332408 - [lld] Make helpers static. NFC.

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Tue May 15 15:01:55 PDT 2018


Author: d0k
Date: Tue May 15 15:01:54 2018
New Revision: 332408

URL: http://llvm.org/viewvc/llvm-project?rev=332408&view=rev
Log:
[lld] Make helpers static. NFC.

Modified:
    lld/trunk/ELF/Arch/X86_64.cpp
    lld/trunk/ELF/SymbolTable.cpp
    lld/trunk/wasm/Driver.cpp
    lld/trunk/wasm/InputChunks.cpp

Modified: lld/trunk/ELF/Arch/X86_64.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Arch/X86_64.cpp?rev=332408&r1=332407&r2=332408&view=diff
==============================================================================
--- lld/trunk/ELF/Arch/X86_64.cpp (original)
+++ lld/trunk/ELF/Arch/X86_64.cpp Tue May 15 15:01:54 2018
@@ -573,7 +573,7 @@ void RetpolineZNow<ELFT>::writePlt(uint8
   write32le(Buf + 8, -TargetInfo::getPltEntryOffset(Index) - 12);
 }
 
-template <class ELFT> TargetInfo *getTargetInfo() {
+template <class ELFT> static TargetInfo *getTargetInfo() {
   if (Config->ZRetpolineplt) {
     if (Config->ZNow) {
       static RetpolineZNow<ELFT> T;

Modified: lld/trunk/ELF/SymbolTable.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SymbolTable.cpp?rev=332408&r1=332407&r2=332408&view=diff
==============================================================================
--- lld/trunk/ELF/SymbolTable.cpp (original)
+++ lld/trunk/ELF/SymbolTable.cpp Tue May 15 15:01:54 2018
@@ -598,9 +598,9 @@ Symbol *SymbolTable::find(StringRef Name
 // This is used to handle lazy symbols. May replace existent
 // symbol with lazy version or request to Fetch it.
 template <class ELFT, typename LazyT, typename... ArgT>
-void replaceOrFetchLazy(StringRef Name, InputFile &File,
-                        llvm::function_ref<InputFile *()> Fetch,
-                        ArgT &&... Arg) {
+static void replaceOrFetchLazy(StringRef Name, InputFile &File,
+                               llvm::function_ref<InputFile *()> Fetch,
+                               ArgT &&... Arg) {
   Symbol *S;
   bool WasInserted;
   std::tie(S, WasInserted) = Symtab->insert(Name);

Modified: lld/trunk/wasm/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/Driver.cpp?rev=332408&r1=332407&r2=332408&view=diff
==============================================================================
--- lld/trunk/wasm/Driver.cpp (original)
+++ lld/trunk/wasm/Driver.cpp Tue May 15 15:01:54 2018
@@ -98,11 +98,13 @@ static const opt::OptTable::Info OptInfo
 #undef OPTION
 };
 
+namespace {
 class WasmOptTable : public llvm::opt::OptTable {
 public:
   WasmOptTable() : OptTable(OptInfo) {}
   opt::InputArgList parse(ArrayRef<const char *> Argv);
 };
+} // namespace
 
 // Set color diagnostics according to -color-diagnostics={auto,always,never}
 // or -no-color-diagnostics flags.

Modified: lld/trunk/wasm/InputChunks.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/InputChunks.cpp?rev=332408&r1=332407&r2=332408&view=diff
==============================================================================
--- lld/trunk/wasm/InputChunks.cpp (original)
+++ lld/trunk/wasm/InputChunks.cpp Tue May 15 15:01:54 2018
@@ -23,7 +23,7 @@ using namespace llvm::support::endian;
 using namespace lld;
 using namespace lld::wasm;
 
-StringRef ReloctTypeToString(uint8_t RelocType) {
+static StringRef ReloctTypeToString(uint8_t RelocType) {
   switch (RelocType) {
 #define WASM_RELOC(NAME, REL) case REL: return #NAME;
 #include "llvm/BinaryFormat/WasmRelocs.def"




More information about the llvm-commits mailing list