[PATCH] D45736: [SimplifyLibcalls] Replace locked IO with unlocked IO

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

In https://reviews.llvm.org/D45736#1103716, @xbolva00 wrote:

> > ! In https://reviews.llvm.org/D45736#1103697, @echristo wrote:
> >  We're definitely seeing problems here and I'm not sure if it's safe in general.
> > 
> >   ...
> > 
> > -eric
>
> There was a llvm-dev thread. but only me, Eli and Han participated. There was a discussion that Linux && GNU check would be enough to be sure we have these unlocked functions.
>
> Can you write here your problems?
>
> The transformation logic is safe I think, we are sure via capture tracker that if fileptr cannot be captured & fileptr comes from fopen, we can use unlocked variants.
>
> But I cannot do tests everywhere with every glibc versions, every XY system :)
>
> And If almost nobody write comments (btw, I would like say thanks to Eli for advices not only in this patch) during review (and he wrote the code is OK), llvm-dev thread, we cannot do this transformation better, safer (?) ...


Ben's fix and comment on the patch were the problems I was seeing. More so that no actual committer to the project approved - no one I've spoken to knows who rja is.


Repository:
  rL LLVM

https://reviews.llvm.org/D45736