[PATCH] D45736: [SimplifyLibcalls] Replace locked IO with unlocked IO

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added a comment.

In https://reviews.llvm.org/D45736#1103697, @echristo wrote:

> In https://reviews.llvm.org/D45736#1096871, @rja wrote:
>
> > LGTM.
> >
> > We should merge this patch to  see the impact of this patch on real code bases. We can still revert it if too many problems.
>
>
> We're definitely seeing problems here and I'm not sure if it's safe in general. Also, before committing we'd prefer that actual committers review patches - and I'm not seeing that you're an active committer to the project. If so, could you let us know who you are?
>
> In particular, for this patch I think it should have gone to llvm-dev first as Eli suggested.
>
> Thanks.
>
> -eric


There was a thread there, but only me, Eli and Han participated. There was a discussion that Linux && GNU check would be enough to be sure we have these unlocked functions.

Can you write here your problems?


Repository:
  rL LLVM

https://reviews.llvm.org/D45736