[PATCH] D46826: [VPlan] Add VPlan based sinkInstructions utility.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorizationPlanner.cpp:20
+
+#define DEBUG_TYPE "loop-vectorize"
+
----------------
dcaballe wrote:
> I'm using independent DEBUG_TYPE in D44338 for VPlan verifier and HCFGConstruction files. I guess we should be consistent. We could use 'loop-vectorize' for all of them or also use an independent one for this.
I think using 'loop-vectorize' everywhere is that we can use `-debug-only=loop-vectorize` to get the complete picture.


================
Comment at: unittests/Transforms/Vectorize/VPlanTest.cpp:55
+TEST(VPInstructionTest, sinkInstructions) {
+  // Create some dummy instructions, we need those for the SinkAfter mapping.
+  LLVMContext Context;
----------------
This version leaks the created instructions. I will clean that up in the next update (or before committing).


https://reviews.llvm.org/D46826