[PATCH] D46826: [VPlan] Add VPlan based sinkInstructions utility.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 146858.
fhahn marked 2 inline comments as done.
fhahn edited the summary of this revision.
fhahn added a comment.

Thanks Diego, LoopVectorizationPlanner is not the right place, initially I was not sure where to put it. I updated the patch to move sinkInstructions to VPlanHCFGTransforms. I've made this a class with static member functions, as sinkInstructions gets access to getUnderlyingVal via a friend class.

I agree that in the long term, we should migrate to a VPlan native handling of the interleave group handling. I suppose that would be something that could be done independently. Maybe it would be worth collecting a set of tasks/cleanups that aren't blocked on other changes.


https://reviews.llvm.org/D46826

Files:
  lib/Transforms/Vectorize/CMakeLists.txt
  lib/Transforms/Vectorize/VPlanHCFGTransforms.cpp
  lib/Transforms/Vectorize/VPlanHCFGTransforms.h
  lib/Transforms/Vectorize/VPlanValue.h
  unittests/Transforms/Vectorize/VPlanTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46826.146858.patch
Type: text/x-patch
Size: 7025 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180515/53058a4e/attachment.bin>