[PATCH] D46831: [DWARF] Refactor callback usage for .debug_line error handling

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 14 07:27:14 PDT 2018


jhenderson created this revision.
jhenderson added reviewers: JDevlieghere, dblaikie, probinson.

As suggested by @JDevlieghere, I have switched the callback that takes a string in the debug line error handling, with one that takes an `Error`. This allows using the same default function for both recoverable and unrecoverable errors. Further, to more clearly define which is which, I have renamed the two callbacks.

There are also some other minor tidy-ups/simplifications in relation to this change.


Repository:
  rL LLVM

https://reviews.llvm.org/D46831

Files:
  include/llvm/DebugInfo/DWARF/DWARFContext.h
  include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
  lib/DebugInfo/DWARF/DWARFContext.cpp
  lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46831.146604.patch
Type: text/x-patch
Size: 21797 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180514/b6192cb9/attachment-0001.bin>


More information about the llvm-commits mailing list