[PATCH] D45559: [WebAssembly] Add Wasm personality and usesWindowsEHInstructions()

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

In https://reviews.llvm.org/D45559#1091152, @aheejin wrote:

> But currently the term 'use funclets', both in function names and comments / error messages, is being used to mean both 'use windows EH IR' and 'use outlined funclets' in the code.
>  Currently 'use funclet' can mean either thing in LLVM. But in wasm we only want the IR level behavior but not the outlining behavior. An example of the latter, which deals with the real function outlining, is this code <https://github.com/llvm-mirror/llvm/blob/3372396f7080f9ea0c335dab0441c65a39a048f1/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp#L100-L120> preparing information for LSDA generation for funclets, which we are not gonna use in wasm.


Right, I guess my point was that to me 'funclet' refers to just the outlined bits of code and therefore wouldn't apply to wasm.

> Now I'm thinking that maybe we should use isFuncletEHPersonality for the use cases here I replaced with usesWindowsEHInstructions, and come up with a new name to give to the use cases that pertain to real outlined small functions.

I'm a little confused; this seems backwards to me. (I think that means that I agree with @majnemer that the stuff outside of AsmPrinter where the outlining happens should be renamed). That will hopefully not be too much yak-shaving. I do think it will result in much more understandable code than not doing it though.


Repository:
  rL LLVM

https://reviews.llvm.org/D45559