[PATCH] D45559: [WebAssembly] Add Wasm personality and usesWindowsEHInstructions()

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 10 11:26:12 PDT 2018


aheejin added a comment.

Let me clarify. So there are the two options:

1. Use 'funclet' to only mean outlined funclet in AsmPrinter

I guess @dschuff endorses this, right? I'm not sure what @majnemer meant. Actually this is what I first tried to do in this patch, but this seems to be a harder way now, because as I said, the term funclet is used to mean a lot of things and being used everywhere including both llvm and clang in all sorts of method names in comments, not only this personality functions.

2. Leave the uses of 'funclet' as they are, delete `usesWindowsEHInstructions` function and change the uses of them back to `isFuncletEHPersonality`, and create something like `usesFuncletLSDA` to be used in the cases that only pertain to real outlined funclets. This seems to be less work, because we don't need to change the uses of 'funclet' everywhere...


Repository:
  rL LLVM

https://reviews.llvm.org/D45559





More information about the llvm-commits mailing list