[PATCH] D43092: [DebugInfo] Prevent infinite recursion for malformed DWARF

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 30 10:28:49 PDT 2018


Sorry - could we revisit this?

I think my concerns expressed still haven't been resolved:

"Could you check the revision history here? I'm pretty sure the first
version of this I reviewed from Greg wasn't recursive - and then it became
recursive at some point to handle something needed, but maybe those
decisions need to be reexamined?" (& related comments back there)

On Mon, Apr 30, 2018 at 10:06 AM Jonas Devlieghere via Phabricator <
reviews at reviews.llvm.org> wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL331200: [DebugInfo] Prevent infinite recursion for
> malformed DWARF (authored by JDevlieghere, committed by ).
>
> Changed prior to commit:
>   https://reviews.llvm.org/D43092?vs=144485&id=144582#toc
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D43092
>
> Files:
>   llvm/trunk/lib/DebugInfo/DWARF/DWARFDie.cpp
>   llvm/trunk/test/tools/llvm-dwarfdump/X86/invalid_abstract_origin.s
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180430/2bf8b9de/attachment.html>


More information about the llvm-commits mailing list