<div dir="ltr">Sorry - could we revisit this?<br><br>I think my concerns expressed still haven't been resolved:<br><br>"<span style="color:rgb(33,33,33)">Could you check the revision history here? I'm pretty sure the first version of this I reviewed from Greg wasn't recursive - and then it became recursive at some point to handle something needed, but maybe those decisions need to be reexamined?" (& related comments back there)</span></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Apr 30, 2018 at 10:06 AM Jonas Devlieghere via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL331200: [DebugInfo] Prevent infinite recursion for malformed DWARF (authored by JDevlieghere, committed by ).<br>
<br>
Changed prior to commit:<br>
  <a href="https://reviews.llvm.org/D43092?vs=144485&id=144582#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/D43092?vs=144485&id=144582#toc</a><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D43092" rel="noreferrer" target="_blank">https://reviews.llvm.org/D43092</a><br>
<br>
Files:<br>
  llvm/trunk/lib/DebugInfo/DWARF/DWARFDie.cpp<br>
  llvm/trunk/test/tools/llvm-dwarfdump/X86/invalid_abstract_origin.s<br>
<br>
</blockquote></div>