[PATCH] D46145: Use a buffer when allocating relocations

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added a comment.

In https://reviews.llvm.org/D46145#1081212, @ruiu wrote:

> I tried this patch and found that at least for Chrome, we wasted memory by calling reserve() on ".data.rel.ro" sections. Such section in Chrome doesn't add any item to Sec.Relocations while their Rels.size() is relatively large, so reserved memory is totally wasted. If you don't call reserve on such section, you can save almost the same memory as you did in this patch. Can you take a look?


The issue is that chrome is linked with -pie. The section in question has a lot of

.quad foo
.quad bar
...

They become dynamic relocation instead of static ones.

I don't see how to predict that in general. I will try removing the reserve in combination with this patch.


https://reviews.llvm.org/D46145