[PATCH] D46145: Use a buffer when allocating relocations

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 27 09:13:46 PDT 2018


ruiu added a comment.

I tried this patch and found that at least for Chrome, we wasted memory by calling reserve() on ".data.rel.ro" sections. Such section in Chrome doesn't add any item to Sec.Relocations while their Rels.size() is relatively large, so reserved memory is totally wasted. If you don't call reserve on such section, you can save almost the same memory as you did in this patch. Can you take a look?


https://reviews.llvm.org/D46145





More information about the llvm-commits mailing list