[PATCH] D45907: AMDGPU/GlobalISel: Implement select() for @llvm.amdgcn.cvt.pkrtz

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 26 21:40:07 PDT 2018


tstellar added inline comments.


================
Comment at: test/CodeGen/AMDGPU/GlobalISel/inst-select-amdgcn.cvt.pkrtz.mir:4-8
+  define void @cvt_pkrtz(i32 addrspace(1)* %global0) { ret void }
+
+  declare <2 x half> @llvm.amdgcn.cvt.pkrtz(float, float) #0
+
+  attributes #0 = { readnone speculatable }
----------------
arsenm wrote:
> I think you can drop the IR section, even with the intrinsic declaration
It complained about function cvt_pkrtz not being defined in the IR, but I was able to drop the intrinsic declaration.


Repository:
  rL LLVM

https://reviews.llvm.org/D45907





More information about the llvm-commits mailing list