[PATCH] D46173: [XRay][compiler-rt+docs] Introduce __xray_log_init_mode(...).

[Dean Michael Berris via Phabricator via llvm-commits]

dberris created this revision.
dberris added reviewers: eizan, kpw, echristo, pelikan.

This addresses http://llvm.org/PR36790.

The change Deprecates a number of functions and types in
`include/xray/xray_log_interface.h` to recommend using string-based
configuration of XRay through the __xray_log_init_mode(...) function. In
particular, this deprecates the following:

- `__xray_set_log_impl(...)` -- users should instead use the

`__xray_log_register_mode(...)` and `__xray_log_select_mode(...)` APIs.

- `__xray_log_init(...)` -- users should instead use the

`__xray_log_init_mode(...)` function, which also requires using the
`__xray_log_register_mode(...)` and `__xray_log_select_mode(...)`
functionality.

- `__xray::FDRLoggingOptions` -- in following patches, we'll be

migrating the FDR logging implementations (and tests) to use the
string-based configuration. In later stages we'll remove the
`__xray::FDRLoggingOptions` type, and ask users to migrate to using the
string-based configuration mechanism instead.

- `__xray::BasicLoggingOptions` -- same as `__xray::FDRLoggingOptions`,

we'll be removing this type later and instead rely exclusively on the
string-based configuration API.

We also update the documentation to reflect the new advice and remove
some of the deprecated notes.


https://reviews.llvm.org/D46173

Files:
  compiler-rt/include/xray/xray_log_interface.h
  compiler-rt/lib/xray/xray_log_interface.cc
  compiler-rt/test/xray/TestCases/Posix/logging-modes.cc
  llvm/docs/XRay.rst

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46173.144281.patch
Type: text/x-patch
Size: 17709 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180427/a3b83e42/attachment.bin>