[PATCH] D45879: [AsmMatcher] Extend PredicateMethod with optional DiagnosticPredicate

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: include/llvm/MC/MCParser/MCTargetAsmParser.h:158
+//    opnd2 could be an 'immediate of range [-8, 7]'
+//    opnd2 could be a  'register + decoration suffix'.
+//
----------------
SjoerdMeijer wrote:
> Sorry, one more nit while we wait for Oliver's lgtm: is "decoration suffix" the right terminology here? Should this e.g. be "access suffix", or something else?
Agreed, 'decoration suffix' may not be the right terminology, although I'm not sure if 'access suffix' is much clearer. How about just using 'shift/extend' ?


https://reviews.llvm.org/D45879