[PATCH] D45879: [AsmMatcher] Extend PredicateMethod with optional DiagnosticPredicate

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 24 03:55:24 PDT 2018


SjoerdMeijer added inline comments.


================
Comment at: include/llvm/MC/MCParser/MCTargetAsmParser.h:158
+//    opnd2 could be an 'immediate of range [-8, 7]'
+//    opnd2 could be a  'register + decoration suffix'.
+//
----------------
Sorry, one more nit while we wait for Oliver's lgtm: is "decoration suffix" the right terminology here? Should this e.g. be "access suffix", or something else?


https://reviews.llvm.org/D45879





More information about the llvm-commits mailing list