[PATCH] D45879: [AsmMatcher] Extend PredicateMethod with optional DiagnosticPredicate

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

Looks good to me too, just some comments about typos/nits inlined from my side. I will let Oliver approve as he did most of the work in this area.



================
Comment at: include/llvm/MC/MCParser/MCTargetAsmParser.h:142
+
+// When an operand is parsed, the assembler will try iterate through a set of
+// possible operand classes that operand might match and call the corresponding
----------------
nit: try -> try to


================
Comment at: include/llvm/MC/MCParser/MCTargetAsmParser.h:143
+// When an operand is parsed, the assembler will try iterate through a set of
+// possible operand classes that operand might match and call the corresponding
+// PredicateMethod to determine that.
----------------
nit: that operand -> that the operand


================
Comment at: include/llvm/MC/MCParser/MCTargetAsmParser.h:161
+// If opnd2 is a valid register, but with a wrong decoration suffix, it makes
+// little sense to give a diagnostice that the operand should be an immediate
+// in range [-8, 7].
----------------
typo: diagnostice


https://reviews.llvm.org/D45879