[PATCH] D45879: [AsmMatcher] Extend PredicateMethod with optional DiagnosticPredicate

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a subscriber: asb.
fhahn added a comment.

IMO this leads to a nice improvement for the assembler diagnostics as shown https://reviews.llvm.org/D45880. I think it would be great if we could also make the recent improvements to usability more visible, so they can get wider usage across backends.



================
Comment at: include/llvm/MC/MCParser/MCTargetAsmParser.h:136
 
+enum DiagnosticPredicateTy {
+  DP_Match,
----------------
enum class ?


https://reviews.llvm.org/D45879