[PATCH] D45918: [lit] Generate a single lit cfg file for tests that require dotest.py

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a subscriber: asmith.
stella.stamenova added a comment.

I don't have commit permissions, @JDevlieghere or @asmith, would you be kind enough to check it in?



================
Comment at: test/CMakeLists.txt:125
 
+# The framework path is passed to the test arguments as $<TARGET_FILE_DIR:liblldb>. This won't work in the
+# LLDB_DOTEST_ARGS when using a generator that supports multiple configurations such as Visual Studio,
----------------
JDevlieghere wrote:
> Is there any disadvantage to moving this and the next set or arguments to the `LLDB_EXECUTABLE_PATH_ARGS_STR`?
They need to be in the common arguments since they need to be appended in both cases (for lit and for dotest).

If you are asking whether if we put them in LLDB_EXECUTABLE_PATH_ARGS_STR and did the build_mode replacement it would change them - it won't since they won't contain CMAKE_CFG_INTDIR.

If you are asking whether we can append them to LLDB_EXECUTABLE_PATH_ARGS (without STR), that's not sufficient either since we need them to end up in the lit file as well.



Repository:
  rL LLVM

https://reviews.llvm.org/D45918