[PATCH] D45918: [lit] Generate a single lit cfg file for tests that require dotest.py

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova updated this revision to Diff 143450.
stella.stamenova marked an inline comment as done.
stella.stamenova added a comment.

Fix a couple of comments to be more accurate and fix a typo


Repository:
  rL LLVM

https://reviews.llvm.org/D45918

Files:
  test/CMakeLists.txt


Index: test/CMakeLists.txt
===================================================================
--- test/CMakeLists.txt
+++ test/CMakeLists.txt
@@ -123,7 +123,7 @@
 endif()
 
 # The framework path is passed to the test arguments as $<TARGET_FILE_DIR:liblldb>. This won't work in the
-# LLDB_DOTEST_ARGS when using a generator that supports multiple configurations such as Visual Studio,
+# LLDB_DOTEST_ARGS_STR when using a generator that supports multiple configurations such as Visual Studio,
 # but since the framework is currently confined to Darwin/Apple, we can leave it as is.
 if(LLDB_BUILD_FRAMEWORK)
   list(APPEND LLDB_TEST_COMMON_ARGS --framework $<TARGET_FILE_DIR:liblldb>)
@@ -135,7 +135,7 @@
 endif()
 
 # In some cases, DEBUGSERVER_PATH is expressed as $<TARGET_FILE:debugserver>. This won't work in the
-# LLDB_DOTEST_ARGS when using a generator that supports multiple configurations such as Visual Studio,
+# LLDB_DOTEST_ARGS_STR when using a generator that supports multiple configurations such as Visual Studio,
 # but since debugserver is currently confined to Darwin/Apple, we can leave it as is.
 if(CMAKE_HOST_APPLE)
   list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH})
@@ -165,7 +165,7 @@
   ${CMAKE_CURRENT_BINARY_DIR}/lldb-dotest.configured
   )
 # We need this to expand the generator expressions. TARGET_FILE_DIR is OK here because we want to
-# generate a coopy of lldb-dotest per configuration.
+# generate a copy of lldb-dotest per configuration.
 file(GENERATE
   OUTPUT
   $<TARGET_FILE_DIR:lldb>/lldb-dotest


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45918.143450.patch
Type: text/x-patch
Size: 1556 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180421/8c8fc36a/attachment.bin>