[PATCH] D45894: asan: Mark printf-4.c as unsupported on Windows.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 20 11:40:04 PDT 2018


pcc created this revision.
pcc added a reviewer: rnk.
Herald added a subscriber: kubamracek.

Although sprintf is not intercepted on Windows, this test can pass
if sprintf calls memmove, which is intercepted, so we can't XFAIL it.


https://reviews.llvm.org/D45894

Files:
  compiler-rt/test/asan/TestCases/printf-4.c


Index: compiler-rt/test/asan/TestCases/printf-4.c
===================================================================
--- compiler-rt/test/asan/TestCases/printf-4.c
+++ compiler-rt/test/asan/TestCases/printf-4.c
@@ -2,8 +2,9 @@
 // RUN: %env_asan_opts=check_printf=1 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-ON %s
 // RUN: not %run %t 2>&1 | FileCheck --check-prefix=CHECK-ON %s
 
-// FIXME: sprintf is not intercepted on Windows yet.
-// XFAIL: win32
+// FIXME: sprintf is not intercepted on Windows yet. But this test can
+// pass if sprintf calls memmove, which is intercepted, so we can't XFAIL it.
+// UNSUPPORTED: win32
 
 #include <stdio.h>
 int main() {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45894.143353.patch
Type: text/x-patch
Size: 671 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180420/d0c219af/attachment.bin>


More information about the llvm-commits mailing list