[lld] r330461 - [LLD/PDB] Remove improper assert.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 20 11:36:51 PDT 2018


Author: zturner
Date: Fri Apr 20 11:36:51 2018
New Revision: 330461

URL: http://llvm.org/viewvc/llvm-project?rev=330461&view=rev
Log:
[LLD/PDB] Remove improper assert.

It's possible to have an empty object file, for example if you
just compile an empty .c file.  This file won't have any sections
so asserting that a file has chunks is definitely wrong.

Modified:
    lld/trunk/COFF/PDB.cpp

Modified: lld/trunk/COFF/PDB.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/PDB.cpp?rev=330461&r1=330460&r2=330461&view=diff
==============================================================================
--- lld/trunk/COFF/PDB.cpp (original)
+++ lld/trunk/COFF/PDB.cpp Fri Apr 20 11:36:51 2018
@@ -818,7 +818,6 @@ void PDBLinker::addObjFile(ObjFile *File
   File->ModuleDBI->setObjFileName(Path);
 
   auto Chunks = File->getChunks();
-  assert(!Chunks.empty());
   uint32_t Modi = File->ModuleDBI->getModuleIndex();
   for (Chunk *C : Chunks) {
     auto *SecChunk = dyn_cast<SectionChunk>(C);




More information about the llvm-commits mailing list