[PATCH] D45745: [AMDGPU] Enabled v2.16 literals for VOP3P

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 18 01:34:18 PDT 2018


arsenm added inline comments.


================
Comment at: llvm/trunk/lib/Target/AMDGPU/SIFoldOperands.cpp:157-158
 
   if (Fold.isImm()) {
+    if (MI->getDesc().TSFlags & SIInstrFlags::IsPacked) {
+      // Set op_sel_hi on this operand or bail out if op_sel is already set.
----------------
Is this just handling the case where both halves are the same, or is this supposed to handle the mixed case where either high or low is 0?


Repository:
  rL LLVM

https://reviews.llvm.org/D45745





More information about the llvm-commits mailing list