[PATCH] D45434: [ELF] - Eliminate AssertCommand.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 10 03:09:40 PDT 2018


grimar added inline comments.


================
Comment at: ELF/ScriptParser.cpp:764
 
 SymbolAssignment *ScriptParser::readProvideOrAssignment(StringRef Tok) {
+  if (Tok == "ASSERT")
----------------
ruiu wrote:
> This change might be okay, but this function name has to be changed.
What about `readAssignment`? Since PROVIDE, HIDDEN and ASSERT are an a variants of assignment command.


https://reviews.llvm.org/D45434





More information about the llvm-commits mailing list