[PATCH] D45434: [ELF] - Eliminate AssertCommand.

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola accepted this revision.
espindola added a comment.
This revision is now accepted and ready to land.

I am OK with it once a name is agreed on. I would also be OK with readProvideOrAssignment since ASSERT can be viewed as a odd form of assignment.



================
Comment at: ELF/ScriptParser.cpp:765
 SymbolAssignment *ScriptParser::readProvideOrAssignment(StringRef Tok) {
+  if (Tok == "ASSERT")
+    return make<SymbolAssignment>(".", readAssert(), getCurrentLocation());
----------------
Add a comment saying that the Assert expression returns ., so this is just ". = .".


https://reviews.llvm.org/D45434