[llvm] r329648 - [CachePruning] Fix comment about ext4 per-directory file limit. NFC

[Peter Collingbourne via llvm-commits]

Are you sure about that? I'm pretty sure that before writing that comment I
wrote a small program that created lots of files (not subdirectories) in a
directory until it started getting error messages, which started happening
at around 6000000 files.

Peter

On Mon, Apr 9, 2018 at 5:12 PM, Fangrui Song via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: maskray
> Date: Mon Apr  9 17:12:28 2018
> New Revision: 329648
>
> URL: http://llvm.org/viewvc/llvm-project?rev=329648&view=rev
> Log:
> [CachePruning] Fix comment about ext4 per-directory file limit. NFC
>
> There is a limit on number of subdirectories if dir_nlinks is not
> enabled (31998), but per-directory number of files is not limited.
>
> Modified:
>     llvm/trunk/include/llvm/Support/CachePruning.h
>
> Modified: llvm/trunk/include/llvm/Support/CachePruning.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/
> llvm/Support/CachePruning.h?rev=329648&r1=329647&r2=329648&view=diff
> ============================================================
> ==================
> --- llvm/trunk/include/llvm/Support/CachePruning.h (original)
> +++ llvm/trunk/include/llvm/Support/CachePruning.h Mon Apr  9 17:12:28
> 2018
> @@ -52,9 +52,8 @@ struct CachePruningPolicy {
>    /// the number of files based pruning.
>    ///
>    /// This defaults to 1000000 because with that many files there are
> -  /// diminishing returns on the effectiveness of the cache, and some file
> -  /// systems have a limit on how many files can be contained in a
> directory
> -  /// (notably ext4, which is limited to around 6000000 files).
> +  /// diminishing returns on the effectiveness of the cache, and file
> +  /// systems have a limit on total number of files.
>    uint64_t MaxSizeFiles = 1000000;
>  };
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>



-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180409/a9f2f184/attachment.html>