<div dir="ltr">Are you sure about that? I'm pretty sure that before writing that comment I wrote a small program that created lots of files (not subdirectories) in a directory until it started getting error messages, which started happening at around 6000000 files.<div><br></div><div>Peter</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 9, 2018 at 5:12 PM, Fangrui Song via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: maskray<br>
Date: Mon Apr  9 17:12:28 2018<br>
New Revision: 329648<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=329648&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=329648&view=rev</a><br>
Log:<br>
[CachePruning] Fix comment about ext4 per-directory file limit. NFC<br>
<br>
There is a limit on number of subdirectories if dir_nlinks is not<br>
enabled (31998), but per-directory number of files is not limited.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/<wbr>Support/CachePruning.h<br>
<br>
Modified: llvm/trunk/include/llvm/<wbr>Support/CachePruning.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/CachePruning.h?rev=329648&r1=329647&r2=329648&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/Support/CachePruning.h?<wbr>rev=329648&r1=329647&r2=<wbr>329648&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/<wbr>Support/CachePruning.h (original)<br>
+++ llvm/trunk/include/llvm/<wbr>Support/CachePruning.h Mon Apr  9 17:12:28 2018<br>
@@ -52,9 +52,8 @@ struct CachePruningPolicy {<br>
   /// the number of files based pruning.<br>
   ///<br>
   /// This defaults to 1000000 because with that many files there are<br>
-  /// diminishing returns on the effectiveness of the cache, and some file<br>
-  /// systems have a limit on how many files can be contained in a directory<br>
-  /// (notably ext4, which is limited to around 6000000 files).<br>
+  /// diminishing returns on the effectiveness of the cache, and file<br>
+  /// systems have a limit on total number of files.<br>
   uint64_t MaxSizeFiles = 1000000;<br>
 };<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div>