[llvm] r329287 - ARM: Do not spill CSR to stack on entry to noreturn functions

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 6 15:29:51 PDT 2018


On Fri, Apr 6, 2018 at 2:34 PM Tim Northover <t.p.northover at gmail.com>
wrote:

>
> I disagree with this; or at least I think anyone that reverts this
> patch should commit to diagnosing the issue properly. We've massively
>
messed around the person who submitted this patch. He's been pinging
> diligently for more than a month on both mailing list and IRC. And I
> still think the chances are his patch is fundamentally sound, but has
> unfortunate interactions with UBSan.
>

> We've already let myeisha down; let's not compound that.
>

This violates *https://llvm.org/docs/DeveloperPolicy.html#quality
<https://llvm.org/docs/DeveloperPolicy.html#quality>*
Unless someone is going to land a fix soon, as a build cop who need to keep
sanitizer bots green I had to revert this patch later today. I will be
happy to help to investigate this and reland the patch.


>
> Cheers.
>
> Tim.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180406/e40b7def/attachment.html>


More information about the llvm-commits mailing list