[llvm] r329287 - ARM: Do not spill CSR to stack on entry to noreturn functions

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 6 15:50:07 PDT 2018


> This violates https://llvm.org/docs/DeveloperPolicy.html#quality
> Unless someone is going to land a fix soon, as a build cop who need to keep
> sanitizer bots green I had to revert this patch later today

IMO you're over-egging that. I get that green bots are important, but
if they can't be reproduced by reasonably equipped outsiders then they
absolutely should not be part of the reversion criteria. And that's in
the general case (i.e. without someone we've messed around for a few
months).

I don't absolutely object to a reversion, but I'll be extremely
disappointed if it happens without any other attempt to fix this.

> I will be happy to help to investigate this and reland the patch.

OK, so what's the next step? It's clearly not as simple as running
buildbot_android.sh.

I'm off to bed now

Cheers.

Tim.


More information about the llvm-commits mailing list