[PATCH] D45079: [PowerPC] allow D-form VSX load/store when accessing FrameIndex without offset

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 4 10:06:05 PDT 2018


nemanjai added a comment.

I assume that there are cases where the frame index that doesn't have an offset actually ends up being an address with some displacement and that's the purpose of this patch. What I mean is that I assume that this will sometimes lead to something like:

  li 4, 16
  stxvx 2, 3, 4

Since we'd never have something like:

  li 4, 0
  stxvx 2, 3, 4

as that is simply:
`stxvx 2, 0, 3`

If we have cases of the former, please add a test case (i.e. FrameIndex is used without an offset, but we end up needing a non-zero immediate). If we have a case of the latter, that should be fixed more generally (i.e. we should never have a zero input to an instruction where zero in a register field means literal zero).


https://reviews.llvm.org/D45079





More information about the llvm-commits mailing list