[PATCH] D45079: [PowerPC] allow D-form VSX load/store when accessing FrameIndex without offset

Hiroshi Inoue via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 22:31:39 PDT 2018


inouehrs marked an inline comment as done.
inouehrs added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:3956
+  // the object alignment as we do for a frame index + offset above.
+  if (FrameIndexSDNode *FI = dyn_cast<FrameIndexSDNode>(AddrOp)) {
+    const MachineFrameInfo &MFI = CurDAG->getMachineFunction().getFrameInfo();
----------------
nemanjai wrote:
> Can we just combine this with the above? Perhaps with something like:
> `if (FrameIndexSDNode *FI == dyn_cast<FrameIndexSDNode>(AddrOp.getOpcode() == ISD::ADD ? AddrOp.getOperand(0) : AddrOp))`
Thanks for the advice. Is this better?


https://reviews.llvm.org/D45079





More information about the llvm-commits mailing list