[PATCH] D45154: [x86] Model the direction flag (DF) separately from the rest of EFLAGS.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 2 22:35:14 PDT 2018


chandlerc marked 2 inline comments as done.
chandlerc added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrSystem.td:703
+//===----------------------------------------------------------------------===//
+// VMX Instruction
+let SchedRW = [WriteSystem] in {
----------------
craig.topper wrote:
> This isn't a VMX instruction. It was introduced in the 286. Virtualization has to be aware of it to properly virtualize it.
Sorry, I should have finished reading that sentence in the Intel manual rather than just seeing VMX and running with it. =/ Tried to provide more useful comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D45154





More information about the llvm-commits mailing list