[PATCH] D45154: [x86] Model the direction flag (DF) separately from the rest of EFLAGS.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 2 22:01:17 PDT 2018


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.td:2120
+// EFLAGS management instructions.
+let SchedRW = [WriteALU], Defs = [EFLAGS] in {
 def CLC : I<0xF8, RawFrm, (outs), (ins), "clc", [], IIC_CLC>;
----------------
Don't these also use EFLAGS to pass through the other bits?


================
Comment at: llvm/lib/Target/X86/X86InstrSystem.td:703
+//===----------------------------------------------------------------------===//
+// VMX Instruction
+let SchedRW = [WriteSystem] in {
----------------
This isn't a VMX instruction. It was introduced in the 286. Virtualization has to be aware of it to properly virtualize it.


Repository:
  rL LLVM

https://reviews.llvm.org/D45154





More information about the llvm-commits mailing list