[PATCH] D44979: [ELF] - Make Target::TrapInstr to be uint8_t

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added inline comments.


================
Comment at: ELF/Arch/ARM.cpp:63
   PltHeaderSize = 32;
-  TrapInstr = 0xd4d4d4d4;
+  TrapInstr1 = 0xd4;
   // ARM uses Variant 1 TLS
----------------
This is at least odd, as 0xd4 is not a trap on ARM.

Should we just directly represent the fact that the trap instruction has different sizes in different architectures by using an StringRef or ArrayRef?


https://reviews.llvm.org/D44979