[PATCH] D44979: [ELF] - Make Target::TrapInstr to be uint8_t

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 28 03:55:36 PDT 2018


grimar created this revision.
grimar added reviewers: ruiu, espindola.
Herald added subscribers: arichardson, javed.absar, sdardis, emaste.

Currently, it is 4 bytes and we do not really need it.
All our targets use 1-byte trap atm.

And sometimes it is inconvenient to have 4 bytes, for example
when we fill gaps with traps in `writeTrapInstr`
and want to fill memory area. (see https://reviews.llvm.org/D44775/https://reviews.llvm.org/D44943).


https://reviews.llvm.org/D44979

Files:
  ELF/Arch/ARM.cpp
  ELF/Arch/Mips.cpp
  ELF/Arch/X86.cpp
  ELF/Arch/X86_64.cpp
  ELF/OutputSections.cpp
  ELF/Target.h
  ELF/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44979.140063.patch
Type: text/x-patch
Size: 4023 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180328/d8dc48f1/attachment.bin>


More information about the llvm-commits mailing list