[PATCH] D44811: DWARF] DWARF v5: .debug_rnglists: adding support for DW_RLE_offset_pair and DW_RLE_base_address

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:134
+                           *OffsetPtr - 1);
+      uint64_t Base = Data.getAddress(OffsetPtr);
+      CurrentRanges.push_back(RangeListEntry{EntryOffset, Encoding, Base, 0});
----------------
dblaikie wrote:
> Some of our range dumping can now print which section an address refers to - should we do that for this range dumping? If so, we'd need to extract the section info here, I think?
Currently the section is displayed when we're dumping the specific ranges a DIE refers to (DW_AT_ranges attribute). When we're dumping the contents of the entire .debug_ranges section we don't do it. Do you think we should do it there too?

The full support for .debug_rnglists will turn the rangelists into DWARFAddressRangesVectors, so it will behave the same as the current implementation in this respect.


https://reviews.llvm.org/D44811