[PATCH] D44811: DWARF] DWARF v5: .debug_rnglists: adding support for DW_RLE_offset_pair and DW_RLE_base_address

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:229
+    else {
+      assert(Entry.EntryKind == dwarf::DW_RLE_offset_pair &&
+             "Expected EntryKind to be DW_RLE_offset_pair");
----------------
aprantl wrote:
> Just to be safe: Is this an internal consistency check or should this be an error handler instead?
It's a consistency check. I was debating whether the assert was necessary at all since we're in fairly tightly controlled context, but after Dave's suggestion it's a moot point.


https://reviews.llvm.org/D44811